Fix: Controller handle Hook errors #7081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
bug
nopcoder
suggested changes
Nov 30, 2023
esti/hooks_failure_test.go
Outdated
Comment on lines
38
to
39
| branches: | ||
| - * |
There was a problem hiding this comment.
Think you can pass empty list []
Comment on lines
+2229
to
+2234
| var hookAbortErr *graveler.HookAbortError | ||
| if errors.As(err, &hookAbortErr) { | ||
| log.WithField("run_id", hookAbortErr.RunID).Warn("aborted by hooks") | ||
| cb(w, r, http.StatusPreconditionFailed, err) | ||
| return true | ||
| } |
There was a problem hiding this comment.
The HookAbortErr can hold (wrapped by graveler.ErrPreconditionFailed), so the default handler implementation will return http.StatusPreconditionFailed.
All is left is the logging which I think we should keep in all places we trigger hooks and not in the central location.
My two concerns are:
- logging related to the operation, today we capture run_id tomorrow we will need the full content (ex: source branch and etc)
- the downside in having central error location is we can't map where this error is being used.
There was a problem hiding this comment.
- HookAbortErr already wraps the underlying error from the hook execution.
- Logging is coupled with checking that we actually had a HookAbortErr which brings us back to exactly the same situation where we were - missing handling because we forgot to add the same code block in another operation that uses hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7075
Change Description
Background
Some operations handled pre hook failures returning the appropriate error code and some operations (such as create branch) did not handle HookAbort Errors and as a result server returned 500
Bug Fix
Fixed by moving the hook error handling to a central location under
handleAPIErrorTesting Details
Added new system test to cover the scenario